Mina Choi
11d30bb3d1
여러 줄 주석이 설명보다 경위(예전·실측·지적)를 적고 있어 읽는 사람이 결론을 찾기 어려웠다. - ts·tsx·js·mjs·css·py 478개: 여러 줄 주석은 첫 문장 한 줄로, 과거형·날짜 문장은 삭제 - 주석 위치는 TypeScript 파서·파이썬 tokenize/ast 로 찾는다 — 문자열 안의 # · /* 는 건드리지 않는다 - eslint·ts·noqa·type: ignore 같은 지시 주석은 그대로 둔다 파이썬 275개 정리 전후 AST 동일, TS 298개 주석 뺀 토큰 동일(빈 JSX 주석 10곳만 차이). site·frontend·admin tsc, site vitest 105 passed Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
197 lines
9.0 KiB
Python
197 lines
9.0 KiB
Python
"""places 도메인 e2e — 등록 / 동일 업소 검증 / 사장님 스코프 / 채널 URL 확정 게이트."""
|
|
import uuid
|
|
|
|
from common.enums import ErrorType, LinkChannel, PlaceCategory, SourceType
|
|
|
|
|
|
async def _create_place(client, headers, name="테스트펜션", category=PlaceCategory.LODGING):
|
|
r = await client.post("/v1/place", headers=headers, json={"name": name, "category": category.value})
|
|
assert r.status_code == 200, r.text
|
|
return r.json()
|
|
|
|
|
|
async def test_create_place_starts_unverified(auth_headers, client):
|
|
"""검증: 상호명만으로 사업장을 등록한다."""
|
|
h = await auth_headers("u1")
|
|
body = await _create_place(client, h)
|
|
|
|
assert body["result"]["success"] is True
|
|
assert body["place"]["name"] == "테스트펜션"
|
|
assert body["place"]["status"] == 1 # PlaceStatus.DRAFT
|
|
assert body["place"].get("verified_at") is None # RemoveNoneResponse 로 아예 빠진다
|
|
|
|
|
|
async def test_create_place_rejects_blank_name(auth_headers, client):
|
|
"""검증: 빈 상호명으로 등록."""
|
|
h = await auth_headers("u1")
|
|
r = await client.post("/v1/place", headers=h, json={"name": " ", "category": 1})
|
|
assert r.json()["result"]["code"] == ErrorType.INVALID_REQUEST_DATA.value
|
|
|
|
|
|
async def test_verify_place_opens_collection(auth_headers, client):
|
|
"""검증: 카카오 로컬 결과로 동일 업소를 확정한다."""
|
|
h = await auth_headers("u1")
|
|
pid = (await _create_place(client, h))["place"]["place_id"]
|
|
|
|
r = await client.post(
|
|
f"/v1/place/{pid}/verify",
|
|
headers=h,
|
|
json={
|
|
"external_place_id": "26338954",
|
|
"road_address": "강원특별자치도 양양군 현북면 하조대해안길 3",
|
|
"phone": "033-672-0000",
|
|
"latitude": "38.0451234",
|
|
"longitude": "128.6712345",
|
|
"region_code": "4283025",
|
|
},
|
|
)
|
|
body = r.json()
|
|
assert body["result"]["success"] is True
|
|
assert body["place"]["external_place_id"] == "26338954"
|
|
assert body["place"]["region_code"] == "4283025"
|
|
assert body["place"]["verified_at"] is not None
|
|
|
|
|
|
async def test_duplicate_kakao_place_is_allowed(auth_headers, client):
|
|
"""검증: 같은 사장님이 같은 카카오 장소를 두 사업장에 붙인다."""
|
|
h = await auth_headers("u1")
|
|
first = (await _create_place(client, h, "A펜션"))["place"]["place_id"]
|
|
second = (await _create_place(client, h, "A펜션(중복)"))["place"]["place_id"]
|
|
|
|
await client.post(f"/v1/place/{first}/verify", headers=h, json={"external_place_id": "111"})
|
|
r = await client.post(f"/v1/place/{second}/verify", headers=h, json={"external_place_id": "111"})
|
|
assert r.json()["result"]["success"] is True
|
|
|
|
|
|
async def test_naver_verify_without_external_id(auth_headers, client):
|
|
"""검증: 네이버로 검증한다 — 고유 장소 id 가 없고 도로명주소만 있다."""
|
|
h = await auth_headers("u1")
|
|
body = await _create_place(client, h, "핑크비치펜션")
|
|
pid = body["place"]["place_id"]
|
|
|
|
r = await client.post(f"/v1/place/{pid}/verify", headers=h, json={
|
|
"source": 2, # ExternalPlaceSource.NAVER
|
|
"road_address": "강원특별자치도 양양군 현북면 하조대3길 11",
|
|
"latitude": "38.0219217", "longitude": "128.7221449",
|
|
})
|
|
place = r.json()["place"]
|
|
assert r.json()["result"]["success"] is True
|
|
assert place["verified_at"] is not None
|
|
assert place["external_source"] == 2
|
|
assert place.get("external_place_id") is None
|
|
|
|
|
|
async def test_naver_duplicate_name_and_address_is_allowed(auth_headers, client):
|
|
"""검증: 고유 id 없이 같은 상호명·같은 도로명주소로 두 번 등록한다."""
|
|
h = await auth_headers("u1")
|
|
addr = "강원특별자치도 양양군 현북면 하조대3길 11"
|
|
first = (await _create_place(client, h, "핑크비치펜션"))["place"]["place_id"]
|
|
second = (await _create_place(client, h, "핑크비치펜션"))["place"]["place_id"]
|
|
|
|
await client.post(f"/v1/place/{first}/verify", headers=h, json={"source": 2, "road_address": addr})
|
|
r = await client.post(f"/v1/place/{second}/verify", headers=h, json={"source": 2, "road_address": addr})
|
|
assert r.json()["result"]["success"] is True
|
|
|
|
|
|
async def test_delete_place_removes_it_from_list(auth_headers, client):
|
|
"""사업장을 삭제하면 단건 조회와 목록에서 모두 사라진다."""
|
|
h = await auth_headers("u1")
|
|
pid = (await _create_place(client, h, "삭제할 사업장"))["place"]["place_id"]
|
|
|
|
deleted = await client.delete(f"/v1/place/{pid}", headers=h)
|
|
assert deleted.json()["result"]["success"] is True
|
|
|
|
fetched = await client.get(f"/v1/place/{pid}", headers=h)
|
|
assert fetched.json()["result"]["code"] == ErrorType.PLACE_NOT_FOUND.value
|
|
|
|
|
|
async def test_same_address_different_business_is_allowed(auth_headers, client):
|
|
"""검증: 같은 건물(같은 도로명주소)에 상호명이 다른 두 가게를 등록한다."""
|
|
h = await auth_headers("u1")
|
|
addr = "서울특별시 강남구 테헤란로 1"
|
|
a = (await _create_place(client, h, "1층카페"))["place"]["place_id"]
|
|
b = (await _create_place(client, h, "2층식당"))["place"]["place_id"]
|
|
|
|
assert (await client.post(f"/v1/place/{a}/verify", headers=h, json={"source": 2, "road_address": addr})).json()["result"]["success"] is True
|
|
assert (await client.post(f"/v1/place/{b}/verify", headers=h, json={"source": 2, "road_address": addr})).json()["result"]["success"] is True
|
|
|
|
|
|
async def test_verify_without_any_identifier_is_rejected(auth_headers, client):
|
|
"""검증: 고유 id 도 주소도 없이 확정을 시도한다."""
|
|
h = await auth_headers("u1")
|
|
pid = (await _create_place(client, h))["place"]["place_id"]
|
|
|
|
r = await client.post(f"/v1/place/{pid}/verify", headers=h, json={"source": 2, "phone": "033-000-0000"})
|
|
assert r.json()["result"]["code"] == ErrorType.PLACE_VERIFY_NO_CANDIDATE.value
|
|
|
|
|
|
async def test_place_is_scoped_to_owner(auth_headers, client):
|
|
"""검증: 다른 사장님 계정으로 남의 사업장을 조회한다."""
|
|
h1 = await auth_headers("owner1")
|
|
pid = (await _create_place(client, h1))["place"]["place_id"]
|
|
|
|
h2 = await auth_headers("owner2")
|
|
r = await client.get(f"/v1/place/{pid}", headers=h2)
|
|
assert r.json()["result"]["code"] == ErrorType.PLACE_NOT_FOUND.value
|
|
|
|
|
|
async def test_link_cannot_be_confirmed_before_place_verified(auth_headers, client):
|
|
"""검증: 동일 업소 검증 전에 채널 URL 을 확정하려 한다."""
|
|
h = await auth_headers("u1")
|
|
pid = (await _create_place(client, h))["place"]["place_id"]
|
|
|
|
r = await client.post(
|
|
f"/v1/place/{pid}/link",
|
|
headers=h,
|
|
json={"channel": LinkChannel.YANOLJA.value, "url": "https://www.yanolja.com/pension/1", "discovered_by": SourceType.API.value},
|
|
)
|
|
link_id = r.json()["link"]["link_id"]
|
|
|
|
r = await client.post(f"/v1/place/{pid}/link/{link_id}/confirm", headers=h)
|
|
assert r.json()["result"]["code"] == ErrorType.PLACE_NOT_VERIFIED.value
|
|
|
|
|
|
async def test_confirmed_link_becomes_crawl_target(auth_headers, client):
|
|
"""검증: 검증 통과 후 채널 URL 을 확정한다."""
|
|
h = await auth_headers("u1")
|
|
pid = (await _create_place(client, h))["place"]["place_id"]
|
|
await client.post(f"/v1/place/{pid}/verify", headers=h, json={"external_place_id": "222"})
|
|
|
|
r = await client.post(
|
|
f"/v1/place/{pid}/link",
|
|
headers=h,
|
|
json={"channel": LinkChannel.NAVER_PLACE.value, "url": "https://place.naver.com/1", "discovered_by": SourceType.API.value},
|
|
)
|
|
link_id = r.json()["link"]["link_id"]
|
|
|
|
# 확정 전에는 크롤링 대상이 아니다
|
|
r = await client.get(f"/v1/place/{pid}/link/list", headers=h, params={"confirmed_only": True})
|
|
assert r.json().get("links", []) == []
|
|
|
|
assert (await client.post(f"/v1/place/{pid}/link/{link_id}/confirm", headers=h)).json()["result"]["success"] is True
|
|
|
|
r = await client.get(f"/v1/place/{pid}/link/list", headers=h, params={"confirmed_only": True})
|
|
body = r.json()
|
|
assert len(body["links"]) == 1
|
|
assert body["links"][0]["confirmed_at"] is not None
|
|
|
|
|
|
async def test_confirm_link_twice_is_rejected(auth_headers, client):
|
|
"""검증: 이미 확정된 링크를 다시 확정한다."""
|
|
h = await auth_headers("u1")
|
|
pid = (await _create_place(client, h))["place"]["place_id"]
|
|
await client.post(f"/v1/place/{pid}/verify", headers=h, json={"external_place_id": "333"})
|
|
r = await client.post(f"/v1/place/{pid}/link", headers=h, json={"channel": 1, "url": "https://x.test/1"})
|
|
link_id = r.json()["link"]["link_id"]
|
|
|
|
await client.post(f"/v1/place/{pid}/link/{link_id}/confirm", headers=h)
|
|
r = await client.post(f"/v1/place/{pid}/link/{link_id}/confirm", headers=h)
|
|
assert r.json()["result"]["code"] == ErrorType.LINK_NOT_FOUND.value
|
|
|
|
|
|
async def test_unknown_place_returns_not_found(auth_headers, client):
|
|
"""검증: 없는 place_id 조회."""
|
|
h = await auth_headers("u1")
|
|
r = await client.get(f"/v1/place/{uuid.uuid4()}", headers=h)
|
|
assert r.json()["result"]["code"] == ErrorType.PLACE_NOT_FOUND.value
|