Mina Choi
11d30bb3d1
여러 줄 주석이 설명보다 경위(예전·실측·지적)를 적고 있어 읽는 사람이 결론을 찾기 어려웠다. - ts·tsx·js·mjs·css·py 478개: 여러 줄 주석은 첫 문장 한 줄로, 과거형·날짜 문장은 삭제 - 주석 위치는 TypeScript 파서·파이썬 tokenize/ast 로 찾는다 — 문자열 안의 # · /* 는 건드리지 않는다 - eslint·ts·noqa·type: ignore 같은 지시 주석은 그대로 둔다 파이썬 275개 정리 전후 AST 동일, TS 298개 주석 뺀 토큰 동일(빈 JSX 주석 10곳만 차이). site·frontend·admin tsc, site vitest 105 passed Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
107 lines
4.1 KiB
Python
107 lines
4.1 KiB
Python
"""이용 후기 — 접수·검수·게재."""
|
|
import uuid
|
|
|
|
from sqlalchemy import text
|
|
|
|
from common.enums import PlaceCategory, ReviewStatus, SiteStatus
|
|
from services.review_service import check_body
|
|
|
|
BODY = "마당이 조용해서 오래 앉아 있었습니다. 대청마루에서 보는 저녁 하늘이 좋았어요."
|
|
|
|
|
|
def test_contact_in_the_body_is_refused():
|
|
for bad in ("좋았어요 010-1234-5678 로 연락주세요", "문의는 me@example.com 으로", "짧음"):
|
|
ok, _reason = check_body(bad)
|
|
assert ok is False
|
|
assert check_body(BODY)[0] is True
|
|
|
|
|
|
def test_solution_port_does_not_expose_the_review_review_api():
|
|
import router.router as solution_app
|
|
|
|
paths = solution_app.app.openapi().get("paths", {})
|
|
assert not [p for p in paths if "admin/review" in p]
|
|
assert "/v1/site/review" in paths
|
|
|
|
|
|
async def _seed_place(db_engine, owner_id, *, status=SiteStatus.PUBLISHED) -> str:
|
|
place_id = uuid.uuid4()
|
|
async with db_engine.begin() as conn:
|
|
await conn.execute(
|
|
text("INSERT INTO places (place_id, owner_user_id, name, category, status) "
|
|
"VALUES (:p, :u, :n, :c, 1)"),
|
|
{"p": place_id, "u": owner_id, "n": "스테이,머뭄", "c": PlaceCategory.LODGING.value},
|
|
)
|
|
await conn.execute(
|
|
text("INSERT INTO sites (site_id, place_id, status) VALUES (:s, :p, :st)"),
|
|
{"s": uuid.uuid4(), "p": place_id, "st": status.value},
|
|
)
|
|
return str(place_id)
|
|
|
|
|
|
def _form(place_id, **over):
|
|
body = {"place_id": place_id, "body": BODY, "nickname": "머뭄손님",
|
|
"consent": True, "elapsed_ms": 9000}
|
|
body.update(over)
|
|
return body
|
|
|
|
|
|
async def _rows(db_engine, place_id):
|
|
async with db_engine.begin() as conn:
|
|
result = await conn.execute(
|
|
text("SELECT review_id, status, nickname, submitted_ip_hash FROM place_reviews "
|
|
"WHERE place_id = :p"),
|
|
{"p": uuid.UUID(place_id)},
|
|
)
|
|
return result.all()
|
|
|
|
|
|
async def test_review_is_published_immediately(client, db_engine, owner_id):
|
|
place_id = await _seed_place(db_engine, owner_id)
|
|
|
|
res = await client.post("/v1/site/review", json=_form(place_id))
|
|
|
|
assert res.json()["success"] is True
|
|
rows = await _rows(db_engine, place_id)
|
|
assert len(rows) == 1
|
|
# 사람 검수를 기다리지 않는다 — 기계 필터를 통과하면 그 자리에서 공개다.
|
|
assert rows[0][1] == ReviewStatus.PUBLISHED.value
|
|
# 원문 IP 를 남기지 않는다 — 해시만.
|
|
assert rows[0][3] and len(rows[0][3]) == 64
|
|
|
|
|
|
async def test_unpublished_place_does_not_take_reviews(client, db_engine, owner_id):
|
|
place_id = await _seed_place(db_engine, owner_id, status=SiteStatus.DRAFT)
|
|
|
|
res = await client.post("/v1/site/review", json=_form(place_id))
|
|
|
|
assert res.json()["success"] is False
|
|
assert await _rows(db_engine, place_id) == []
|
|
|
|
|
|
async def test_bot_submissions_are_dropped(client, db_engine, owner_id):
|
|
place_id = await _seed_place(db_engine, owner_id)
|
|
|
|
await client.post("/v1/site/review", json=_form(place_id, company="광고회사"))
|
|
await client.post("/v1/site/review", json=_form(place_id, elapsed_ms=10))
|
|
|
|
assert await _rows(db_engine, place_id) == []
|
|
|
|
|
|
async def test_public_list_shows_it_and_admin_can_take_it_down(client, db_engine, owner_id):
|
|
from services.review_service import ReviewService
|
|
|
|
place_id = await _seed_place(db_engine, owner_id)
|
|
await client.post("/v1/site/review", json=_form(place_id))
|
|
review_id = (await _rows(db_engine, place_id))[0][0]
|
|
|
|
# 화면이 붙은 뒤 받아 가는 목록에 바로 들어 있다.
|
|
public = await client.get(f"/v1/site/reviews?place_id={place_id}")
|
|
assert any(item["reviewId"] == str(review_id) for item in public.json()["items"])
|
|
|
|
# 문제 글은 사후에 내린다 — 내리면 공개 목록에서 빠진다.
|
|
await ReviewService().decide([review_id], publish=False)
|
|
assert (await _rows(db_engine, place_id))[0][1] == ReviewStatus.REJECTED.value
|
|
after = await client.get(f"/v1/site/reviews?place_id={place_id}")
|
|
assert after.json()["items"] == []
|