o2o-site-AEO/solution/backend/tests/test_fact_schema.py
Mina Choi 11d30bb3d1 [chore] solution,admin,ontology: 코드 주석을 한 줄로 — 히스토리 주석 삭제
여러 줄 주석이 설명보다 경위(예전·실측·지적)를 적고 있어 읽는 사람이 결론을 찾기 어려웠다.

- ts·tsx·js·mjs·css·py 478개: 여러 줄 주석은 첫 문장 한 줄로, 과거형·날짜 문장은 삭제
- 주석 위치는 TypeScript 파서·파이썬 tokenize/ast 로 찾는다 — 문자열 안의 # · /* 는 건드리지 않는다
- eslint·ts·noqa·type: ignore 같은 지시 주석은 그대로 둔다

파이썬 275개 정리 전후 AST 동일, TS 298개 주석 뺀 토큰 동일(빈 JSX 주석 10곳만 차이).
site·frontend·admin tsc, site vitest 105 passed

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-09-28 16:05:19 +09:00

149 lines
6.8 KiB
Python

"""fact 테이블 제약 — '사이트에 나가는 값은 (사업장, 단위, key) 당 1건' 이 DB 레벨에서 지켜지는지."""
import uuid
import pytest
from sqlalchemy import text
from sqlalchemy.exc import IntegrityError
from common.enums import (
FACT_STATUS_TRANSITIONS,
LOCKED_FACT_STATUSES,
PUBLISHABLE_FACT_STATUSES,
FactStatus,
PlaceCategory,
PlaceStatus,
SourceType,
)
async def _seed_place(db_engine, owner_id) -> str:
"""검증까지 끝난 사업장 1개를 시드하고 place_id 를 돌려준다."""
pid = uuid.uuid4()
async with db_engine.begin() as conn:
await conn.execute(
text(
"INSERT INTO places (place_id, owner_user_id, name, category, status, external_place_id, verified_at) "
"VALUES (:pid, :cid, :name, :cat, :status, :kakao, now())"
),
{
"pid": pid, "cid": uuid.UUID(owner_id), "name": "테스트펜션",
"cat": PlaceCategory.LODGING.value, "status": PlaceStatus.DRAFT.value,
"kakao": "12345678",
},
)
return str(pid)
async def _insert_fact(db_engine, place_id, key, value, status, unit_id=None):
async with db_engine.begin() as conn:
await conn.execute(
text(
"INSERT INTO place_facts (fact_id, place_id, unit_id, key, value, source_type, status, collected_at) "
"VALUES (:fid, :pid, :uid, :key, :val, :src, :status, now())"
),
{
"fid": uuid.uuid4(), "pid": uuid.UUID(place_id), "uid": unit_id,
"key": key, "val": value, "src": SourceType.CRAWL.value, "status": status.value,
},
)
async def test_published_fact_is_unique_per_place_and_key(db_engine, owner_id):
"""검증: 같은 사업장·같은 key 로 노출 상태 fact 를 두 번 넣는다."""
place_id = await _seed_place(db_engine, owner_id)
await _insert_fact(db_engine, place_id, "check_in_time", "15:00", FactStatus.VERIFIED)
with pytest.raises(IntegrityError):
await _insert_fact(db_engine, place_id, "check_in_time", "16:00", FactStatus.CORRECTED)
async def test_candidates_coexist_with_published_value(db_engine, owner_id):
"""검증: 노출값이 있는 상태에서 재수집 후보를 여러 건 넣는다."""
place_id = await _seed_place(db_engine, owner_id)
await _insert_fact(db_engine, place_id, "check_in_time", "15:00", FactStatus.VERIFIED)
await _insert_fact(db_engine, place_id, "check_in_time", "16:00", FactStatus.PENDING_OWNER)
await _insert_fact(db_engine, place_id, "check_in_time", "14:00", FactStatus.UNVERIFIED)
async with db_engine.begin() as conn:
rows = (await conn.execute(
text("SELECT status FROM place_facts WHERE place_id = :pid AND key = 'check_in_time'"),
{"pid": uuid.UUID(place_id)},
)).all()
assert len(rows) == 3, "노출값 1건 + 후보 2건이 공존해야 한다"
async def test_rejected_fact_frees_the_key(db_engine, owner_id):
"""검증: 기존 값을 REJECTED 로 내린 뒤 같은 key 를 새로 노출한다."""
place_id = await _seed_place(db_engine, owner_id)
await _insert_fact(db_engine, place_id, "check_in_time", "15:00", FactStatus.REJECTED)
await _insert_fact(db_engine, place_id, "check_in_time", "16:00", FactStatus.VERIFIED)
async with db_engine.begin() as conn:
rows = (await conn.execute(
text("SELECT value, status FROM place_facts WHERE place_id = :pid ORDER BY status"),
{"pid": uuid.UUID(place_id)},
)).all()
assert len(rows) == 2, "REJECTED 이력과 새 값이 함께 남아야 한다"
async def test_expired_fact_frees_the_key(db_engine, owner_id):
"""검증: 유효기간이 지나 EXPIRED 로 내린 값과 새 수집값의 공존."""
place_id = await _seed_place(db_engine, owner_id)
await _insert_fact(db_engine, place_id, "cancel_policy", "구 규정", FactStatus.EXPIRED)
await _insert_fact(db_engine, place_id, "cancel_policy", "새 규정", FactStatus.VERIFIED)
async def test_same_key_allowed_across_units(db_engine, owner_id):
"""검증: 객실이 다르면 같은 key 를 각각 가질 수 있는지."""
place_id = await _seed_place(db_engine, owner_id)
unit_a, unit_b = uuid.uuid4(), uuid.uuid4()
async with db_engine.begin() as conn:
for uid, name in ((unit_a, "A동"), (unit_b, "B동")):
await conn.execute(
text("INSERT INTO place_units (unit_id, place_id, name) VALUES (:uid, :pid, :name)"),
{"uid": uid, "pid": uuid.UUID(place_id), "name": name},
)
await _insert_fact(db_engine, place_id, "standard_capacity", "4", FactStatus.VERIFIED, unit_id=unit_a)
await _insert_fact(db_engine, place_id, "standard_capacity", "2", FactStatus.VERIFIED, unit_id=unit_b)
with pytest.raises(IntegrityError): # 같은 객실 안에서 노출값은 여전히 1건
await _insert_fact(db_engine, place_id, "standard_capacity", "6", FactStatus.CORRECTED, unit_id=unit_a)
async def test_unit_fact_and_place_fact_are_separate(db_engine, owner_id):
"""검증: 같은 key 를 사업장 단위와 객실 단위로 동시에 갖는 경우."""
place_id = await _seed_place(db_engine, owner_id)
unit_id = uuid.uuid4()
async with db_engine.begin() as conn:
await conn.execute(
text("INSERT INTO place_units (unit_id, place_id, name) VALUES (:uid, :pid, :name)"),
{"uid": unit_id, "pid": uuid.UUID(place_id), "name": "A동"},
)
await _insert_fact(db_engine, place_id, "has_kitchen", "false", FactStatus.VERIFIED)
await _insert_fact(db_engine, place_id, "has_kitchen", "true", FactStatus.VERIFIED, unit_id=unit_id)
def test_only_verified_and_corrected_are_publishable():
"""검증: 노출 가능 상태 집합(절대규칙 1)."""
assert PUBLISHABLE_FACT_STATUSES == {FactStatus.VERIFIED, FactStatus.CORRECTED}
for status in (FactStatus.UNVERIFIED, FactStatus.PENDING_OWNER, FactStatus.REJECTED, FactStatus.EXPIRED):
assert status not in PUBLISHABLE_FACT_STATUSES
def test_corrected_is_locked_against_auto_update():
"""검증: 사람이 고친 값이 잠기는지(절대규칙 6)."""
assert FactStatus.CORRECTED in LOCKED_FACT_STATUSES
allowed = FACT_STATUS_TRANSITIONS[FactStatus.CORRECTED]
assert FactStatus.UNVERIFIED not in allowed, "자동 수집이 사장님 수정본을 덮어쓸 수 있으면 안 된다"
assert FactStatus.VERIFIED not in allowed
def test_transition_table_covers_every_status():
"""검증: 전이표가 모든 상태를 다루는지."""
assert set(FACT_STATUS_TRANSITIONS) == set(FactStatus)
for src, dests in FACT_STATUS_TRANSITIONS.items():
assert dests, f"{src.name}: 나갈 수 있는 상태가 없다"
for dest in dests:
assert isinstance(dest, FactStatus)